GSoC 2025 blog on the ABI lowering library #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikic Will you please review content-wise? Thanks! |
|
@nikic ping :) |
nikic
reviewed
Oct 1, 2025
There was a problem hiding this comment.
Sorry for not reviewing this earlier, I left some comments now.
As a high level note, I think that for the broader audience of a blog post we should probably focus more on the higher level stuff (concepts, design etc) than code snippets. No really specific suggestions on that though.
vortex73
force-pushed
the
gsoc_2025_final
branch
from
fa70417 to
c6c2ae3
Compare
|
Sorry for the delay. I think I've rectified all the review points. |
nikic
reviewed
Oct 21, 2025
|
For some reason I can't mark old comments as resolved :/ |
vortex73
force-pushed
the
gsoc_2025_final
branch
from
c6c2ae3 to
2236afc
Compare
|
All Done! Thanks for the feedback :) |
asl
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @asl